luoyuliuyin commented on code in PR #42582:
URL: https://github.com/apache/airflow/pull/42582#discussion_r1797493714
##########
airflow/models/taskinstance.py:
##########
@@ -3673,21 +3673,12 @@ def _schedule_downstream_tasks(
assert task
assert task.dag
- # Get a partial DAG with just the specific tasks we want to
examine.
- # In order for dep checks to work correctly, we include ourself (so
- # TriggerRuleDep can check the state of the task we just executed).
- partial_dag = task.dag.partial_subset(
- task.downstream_task_ids,
- include_downstream=True,
- include_upstream=False,
- include_direct_upstream=True,
- )
-
- dag_run.dag = partial_dag
+ # In many scenarios, get a partial DAG is an unsafe operation and
will lead to many bad cases.
Review Comment:
Thank you for the suggestion. I've updated the comment to provide better
context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
