ashb commented on code in PR #42944:
URL: https://github.com/apache/airflow/pull/42944#discussion_r1796974222
##########
dev/breeze/src/airflow_breeze/utils/python_versions.py:
##########
@@ -45,14 +45,12 @@ def get_python_version_list(python_versions: str) ->
list[str]:
return python_version_list
-def check_python_version():
- error = False
- if not sys.version_info >= (3, 9):
- get_console().print("[error]At least Python 3.9 is required to prepare
reproducible archives.\n")
- error = True
- if error:
+def check_python_version(release_provider_packages: bool = False):
+ if not sys.version_info < (3, 12) and release_provider_packages:
Review Comment:
Can you explain more why it's neeeded? ? I don't understand why we can't run
`breeze` commands from 3.12.
Cos `dist/apache_airflow_providers_apache_beam-5.8.1-py3-none-any.whl` got
built for me without any problems on 3.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]