potiuk commented on code in PR #42944:
URL: https://github.com/apache/airflow/pull/42944#discussion_r1797342403
##########
dev/breeze/src/airflow_breeze/utils/python_versions.py:
##########
@@ -45,14 +45,12 @@ def get_python_version_list(python_versions: str) ->
list[str]:
return python_version_list
-def check_python_version():
- error = False
- if not sys.version_info >= (3, 9):
- get_console().print("[error]At least Python 3.9 is required to prepare
reproducible archives.\n")
- error = True
- if error:
+def check_python_version(release_provider_packages: bool = False):
+ if not sys.version_info < (3, 12) and release_provider_packages:
Review Comment:
Whl yes. But part of release managament also (as explained in detail in
linked PRs and commits - part of relase management provider preparation is to
take .sdist packages and install them. See
https://github.com/apache/airflow/pull/42936#issuecomment-2407318919 where I
explained it in detail and linked to the PR that introduced the change.
I think also it saves a lot of time of people for additional explaination
when people who review and comment PRs actually look at the mesages linked PRs
and explanation especialy when the links are explicitly mentioned as the source
of information and are explicitly linked in the commit message. I think it
avoids a lot of duplication of the same information and requires very little
effort from person who is reviewing PRs, especailly if those comments are made
on PRs of those pepple. This allows to save time on multiple explanation at the
expense of extra clicking a link that contains detailed explanation.
It's just pretty tiring to have to explain the same things multiple times to
the same person.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
