dstandish commented on code in PR #43183:
URL: https://github.com/apache/airflow/pull/43183#discussion_r1807159136
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -238,10 +237,6 @@ def set_context(self, ti: TaskInstance, *, identifier: str
| None = None) -> Non
self.handler.setLevel(self.level)
return SetContextPropagate.MAINTAIN_PROPAGATE if
self.maintain_propagate else None
- @cached_property
- def supports_task_context_logging(self) -> bool:
- return "identifier" in inspect.signature(self.set_context).parameters
Review Comment:
It's a good point. I thought about it and figured that it's ok to leave it
even if it is not currently used. Unless there's some backcompat issue with
leaving it but i don't think there is.
Do you see any other backcompat concerns with this PR otherwise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
