potiuk commented on code in PR #43183:
URL: https://github.com/apache/airflow/pull/43183#discussion_r1807236835
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -238,10 +237,6 @@ def set_context(self, ti: TaskInstance, *, identifier: str
| None = None) -> Non
self.handler.setLevel(self.level)
return SetContextPropagate.MAINTAIN_PROPAGATE if
self.maintain_propagate else None
- @cached_property
- def supports_task_context_logging(self) -> bool:
- return "identifier" in inspect.signature(self.set_context).parameters
Review Comment:
Yeah. I think we should drop it - and actually - if we are going to add
documentation for Airlfow 3, I think we should promote and look more closely
into open-telemetry trace integration, which is essentially doing exactly what
have been done here (and more).
Open Telemetry span is equivalent of the identifier, but there is already
tooling (all tools that support open-telemetry spans) that understand and are
able to visualise spans across distributed systems. So I'd say we should make
it clearer and explain to people on how they can connect those tools to see
relations between things like errors raised in other parts of the system that
are related to particular tasks.
This was a very important point raised in the debugging survey - that it is
difficult to debug issues in a distributed environment, and IMHO open-telemetry
and better integration with it is the answer to that need and maybe we shoudl
somehow think about making it more obvious (and learn ourselves how to do it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
