shubhamraj-git commented on code in PR #43231:
URL: https://github.com/apache/airflow/pull/43231#discussion_r1810286088
##########
airflow/ui/src/pages/DagsList/DagsList.tsx:
##########
@@ -200,21 +200,33 @@ export const DagsList = () => {
<Heading py={3} size="md">
{pluralize("DAG", data?.total_entries)}
</Heading>
- {display === "card" ? (
- <Select
- data-testid="sort-by-select"
- onChange={handleSortChange}
- placeholder="Sort by…"
- value={orderBy}
- variant="flushed"
- width="200px"
- >
- <option value="dag_id">Sort by DAG ID (A-Z)</option>
- <option value="-dag_id">Sort by DAG ID (Z-A)</option>
- </Select>
- ) : (
- false
- )}
+ <Select
+ data-testid="sort-by-select"
+ onChange={handleSortChange}
+ placeholder="Sort by…"
+ value={orderBy}
+ variant="flushed"
+ width="200px"
+ >
+ <option value="dag_display_name">Sort by Display Name
(A-Z)</option>
Review Comment:
In discussion with @bbovenzi ,
The thought behind removing the `dag id` is that, `dag_display_name` has a
fall back search for `dag id`.
But I also think since user expectation would be that they are sorting based
upon `dag_display_name` and since it's not a mandatory field, it would have
many null values, and probably it would end with sorting some field with
`dag_display_name` and other with `dag id`. Maybe we should have this info
somewhere (hover) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
