bbovenzi commented on code in PR #43231:
URL: https://github.com/apache/airflow/pull/43231#discussion_r1811065708
##########
airflow/ui/src/pages/DagsList/DagsList.tsx:
##########
@@ -200,21 +200,33 @@ export const DagsList = () => {
<Heading py={3} size="md">
{pluralize("DAG", data?.total_entries)}
</Heading>
- {display === "card" ? (
- <Select
- data-testid="sort-by-select"
- onChange={handleSortChange}
- placeholder="Sort by…"
- value={orderBy}
- variant="flushed"
- width="200px"
- >
- <option value="dag_id">Sort by DAG ID (A-Z)</option>
- <option value="-dag_id">Sort by DAG ID (Z-A)</option>
- </Select>
- ) : (
- false
- )}
+ <Select
+ data-testid="sort-by-select"
+ onChange={handleSortChange}
+ placeholder="Sort by…"
+ value={orderBy}
+ variant="flushed"
+ width="200px"
+ >
+ <option value="dag_display_name">Sort by Display Name
(A-Z)</option>
Review Comment:
I definitely want to move the new UI to only use `dag_display_name`. dag_id
is only a detail the user needs for debugging. But yes, we need to update our
sorting in FastAPI to fallback to dag_id just like we do for search query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
