potiuk commented on code in PR #43123:
URL: https://github.com/apache/airflow/pull/43123#discussion_r1811395460
##########
airflow/utils/cli.py:
##########
@@ -140,10 +141,17 @@ def _build_metrics(func_name, namespace):
:return: dict with metrics
"""
sub_commands_to_check = {"users", "connections"}
+ sub_commands_to_check_based_upon_key = {"variables"}
sensitive_fields = {"-p", "--password", "--conn-password"}
full_command = list(sys.argv)
sub_command = full_command[1] if len(full_command) > 1 else None
- if sub_command in sub_commands_to_check:
+ # For cases when value in variables have sensitive value
+ if sub_command in sub_commands_to_check_based_upon_key:
+ key = full_command[-2] if len(full_command) > 3 else None
Review Comment:
Yeah. Also it's good for the future, when we will separate API package
(after 3.0 likely) -this is way more "standalone" and simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
