shubhamraj-git commented on code in PR #43123:
URL: https://github.com/apache/airflow/pull/43123#discussion_r1806426162
##########
airflow/utils/cli.py:
##########
@@ -140,10 +141,17 @@ def _build_metrics(func_name, namespace):
:return: dict with metrics
"""
sub_commands_to_check = {"users", "connections"}
+ sub_commands_to_check_based_upon_key = {"variables"}
sensitive_fields = {"-p", "--password", "--conn-password"}
full_command = list(sys.argv)
sub_command = full_command[1] if len(full_command) > 1 else None
- if sub_command in sub_commands_to_check:
+ # For cases when value in variables have sensitive value
+ if sub_command in sub_commands_to_check_based_upon_key:
+ key = full_command[-2] if len(full_command) > 3 else None
Review Comment:
I think this is under wrapper and used before action logging, we need to
change the value at this moment only. They have implemented same design for -p
(password) instead of using the mask_secret and saving it's pattern, they
changed here itself, since this itself will be logged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
