ryanahamilton commented on code in PR #43330:
URL: https://github.com/apache/airflow/pull/43330#discussion_r1813487579
##########
airflow/ui/src/theme.ts:
##########
@@ -67,8 +72,16 @@ const theme = extendTheme({
},
semanticTokens: {
colors: {
- "subtle-bg": { _dark: "gray.900", _light: "blue.50" },
- "subtle-text": { _dark: "blue.500", _light: "blue.600" },
+ /* eslint-disable perfectionist/sort-objects */
+ contrast: { _dark: "blue.200", _light: "blue.600" },
+ focusRing: "blue.500",
+ fg: { _dark: "blue.600", _light: "blue.400" },
+ emphasized: { _dark: "blue.700", _light: "blue.300" },
+ solid: { _dark: "blue.800", _light: "blue.200" },
+ muted: { _dark: "blue.900", _light: "blue.100" },
Review Comment:
Should these token names be more specific, e.g. bgMuted? Id expect this
color to be different for something like muted text (e.g. bodyTextMuted).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
