ryanahamilton commented on PR #43330: URL: https://github.com/apache/airflow/pull/43330#issuecomment-2435927720
In v3 it appears that they are tokens per color palette, so something like `"blue.muted"` would probably be more inline with how they use them. On Thu, Oct 24, 2024 at 10:24 AM Brent Bovenzi ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In airflow/ui/src/theme.ts > <https://github.com/apache/airflow/pull/43330#discussion_r1815450840>: > > > @@ -67,8 +72,16 @@ const theme = extendTheme({ > }, > semanticTokens: { > colors: { > - "subtle-bg": { _dark: "gray.900", _light: "blue.50" }, > - "subtle-text": { _dark: "blue.500", _light: "blue.600" }, > + /* eslint-disable perfectionist/sort-objects */ > + contrast: { _dark: "blue.200", _light: "blue.600" }, > + focusRing: "blue.500", > + fg: { _dark: "blue.600", _light: "blue.400" }, > + emphasized: { _dark: "blue.700", _light: "blue.300" }, > + solid: { _dark: "blue.800", _light: "blue.200" }, > + muted: { _dark: "blue.900", _light: "blue.100" }, > > These are the color names in chakra v3. So I wanted to practice using > them. Which fg and emphasized are the colors for foreground elements like > text, borders, icons. This is a bit exploratory too. I might need to adjust > it later. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/43330#discussion_r1815450840>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAAZQ35PWBX77UAV72ZDMDZ5EULNAVCNFSM6AAAAABQPS32KKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJTGMYTAMJYHE> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
