potiuk commented on code in PR #42947:
URL: https://github.com/apache/airflow/pull/42947#discussion_r1814937504
##########
providers/src/airflow/providers/oracle/hooks/oracle.py:
##########
@@ -350,11 +354,23 @@ def bulk_insert_rows(
self.set_autocommit(conn, False)
cursor = conn.cursor() # type: ignore[attr-defined]
values_base = target_fields or rows[0]
- prepared_stm = "insert into {tablename} {columns} values
({values})".format(
- tablename=table,
- columns="({})".format(", ".join(target_fields)) if target_fields
else "",
- values=", ".join(f":{i}" for i in range(1, len(values_base) + 1)),
- )
+
+ if sequence_column and sequence_name:
Review Comment:
What happens when only sequence_column but no seuence_name (or the other way
round) are specified? I think it should be treated as error. You either need
none or both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
