Lee2532 commented on code in PR #42947:
URL: https://github.com/apache/airflow/pull/42947#discussion_r1816419871
##########
providers/src/airflow/providers/oracle/hooks/oracle.py:
##########
@@ -350,11 +354,23 @@ def bulk_insert_rows(
self.set_autocommit(conn, False)
cursor = conn.cursor() # type: ignore[attr-defined]
values_base = target_fields or rows[0]
- prepared_stm = "insert into {tablename} {columns} values
({values})".format(
- tablename=table,
- columns="({})".format(", ".join(target_fields)) if target_fields
else "",
- values=", ".join(f":{i}" for i in range(1, len(values_base) + 1)),
- )
+
+ if sequence_column and sequence_name:
Review Comment:
That's right.
Currently, an error occurs even if you do not enter either of them.
I'll add a code for that case. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
