romsharon98 commented on code in PR #43456:
URL: https://github.com/apache/airflow/pull/43456#discussion_r1820571764
##########
providers/src/airflow/providers/amazon/aws/transfers/s3_to_dynamodb.py:
##########
@@ -237,10 +237,13 @@ def _load_into_existing_table(self) -> str:
total_items += page.get("Count", 0)
dynamodb_hook.write_batch_data(items=page["Items"])
self.log.info("Number of items loaded: %s", total_items)
+ except Exception as e:
+ # Does not raise errors to keep previous behavior.
+ self.log.warning("Error while loading data from temp table,
deleting temp table. Error: %s", e)
Review Comment:
```suggestion
self.log.warning("Error while loading data from temp table.
Error: %s", e)
```
This log message only shows the error and not really deleting the temp
table, we have a log after it that said deleting temp table. So I think better
removing it from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
