potiuk commented on code in PR #43529:
URL: https://github.com/apache/airflow/pull/43529#discussion_r1824041424
##########
dev/breeze/src/airflow_breeze/commands/testing_commands.py:
##########
@@ -877,8 +877,16 @@ def _run_test_command(
)
else:
if shell_params.test_type == "Default":
- if any([arg.startswith("tests") for arg in extra_pytest_args]):
+ if any(
+ [
+ arg.startswith("tests/")
+ or arg.startswith("providers/tests/")
+ or arg.startswith("task_sdk/tests/")
Review Comment:
This is really a workaround - temporary solution to unblock @o-nikolas and
@ambika-garg from running system tests in the way they are used to.
The TODO: and https://github.com/apache/airflow/issues/42632 describe a more
"acurate" and complete solution to it - we will have to split the tests into
three different groups now and treat them separately and run (possibly)
different commands for all three tests so this one is going to change anyway
(and we can implement it better because now logic is spread across different
places and it's very difficult to reason about - it was non-obvious at all for
@ashb when doing #42505 tthat this one should be also changed, which means that
we have to simplify the whole setup here - and splitting to "airflow",
"providers" and "test_sdk" types of tests is a good opportunity to do it
"properly".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
