o-nikolas commented on code in PR #43529:
URL: https://github.com/apache/airflow/pull/43529#discussion_r1825036083
##########
dev/breeze/src/airflow_breeze/commands/testing_commands.py:
##########
@@ -877,8 +877,16 @@ def _run_test_command(
)
else:
if shell_params.test_type == "Default":
- if any([arg.startswith("tests") for arg in extra_pytest_args]):
+ if any(
+ [
+ arg.startswith("tests/")
+ or arg.startswith("providers/tests/")
+ or arg.startswith("task_sdk/tests/")
Review Comment:
Do we need to add `tests/system` as well to this list? Are tests are still
not passing, here is the command that gets run for a system test (when you use
the `--system` flag, `tests/system` is the leading path that should be
removed?).
```
Starting the tests with those pytest arguments: tests/system --verbosity=0
--strict-markers --durations=100 --maxfail=50 --color=yes
--junitxml=/files/test_result-system-postgres.xml --timeouts-order=moi
--setup-timeout=5400 --execution-timeout=5400 --teardown-timeout=5400
--disable-warnings -rfEX --ignore-glob=*/tests/integration
--warning-output-path=/files/warnings-system-postgres.txt --ignore=helm_tests
--ignore=providers/tests/cloudant --ignore=providers/tests/system/cloudant
--ignore=providers/tests/integration/cloudant --no-cov --keep-env-variables
--no-db-cleanup providers/tests/system/amazon/aws/example_athena.py --system
amazon -s --color=no
ERROR: found no collectors for
/opt/airflow/providers/tests/system/amazon/aws/example_athena.py
============================= test session starts
==============================
platform linux -- Python 3.9.20, pytest-8.3.3, pluggy-1.5.0
rootdir: /opt/airflow
configfile: pyproject.toml
plugins: rerunfailures-14.0, xdist-3.6.1, mock-3.14.0, time-machine-2.16.0,
requests-mock-1.12.1, icdiff-0.9, instafail-0.5.0, custom-exit-code-0.3.0,
cov-6.0.0, asyncio-0.24.0, timeouts-1.2.1, anyio-4.6.2.post1, kgb-7.1.1
asyncio: mode=strict, default_loop_scope=function
setup timeout: 5400.0s, execution timeout: 5400.0s, teardown timeout: 5400.0s
collected 0 items / 1 error
==================================== ERRORS
====================================
_______________________ ERROR collecting providers/tests
_______________________
Defining 'pytest_plugins' in a non-top-level conftest is no longer supported:
It affects the entire test suite instead of just below the conftest as
expected.
/opt/airflow/providers/tests/conftest.py
Please move it to a top level conftest file at the rootdir:
/opt/airflow
For more information, visit:
https://docs.pytest.org/en/stable/deprecations.html#pytest-plugins-in-non-top-level-conftest-files
---------- generated xml file: /files/test_result-system-postgres.xml
----------
=========================== short test summary info
============================
ERROR providers/tests - Failed: Defining 'pytest_plugins' in a non-top-level
conftest is no longer supported:
It affects the entire test suite instead of just below the conftest as
expected.
/opt/airflow/providers/tests/conftest.py
Please move it to a top level conftest file at the rootdir:
/opt/airflow
For more information, visit:
https://docs.pytest.org/en/stable/deprecations.html#pytest-plugins-in-non-top-level-conftest-files
========================= 1 warning, 1 error in 0.05s
==========================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
