claw89 commented on code in PR #43446: URL: https://github.com/apache/airflow/pull/43446#discussion_r1826195870
########## providers/src/airflow/providers/google/cloud/hooks/financial_services.py: ########## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from googleapiclient.discovery import Resource, build_from_document + +from airflow.providers.google.common.hooks.base_google import GoogleBaseHook + + +class FinancialServicesHook(GoogleBaseHook): + """ + Hook for interacting with the Google Financial Services API. + + :param discovery_doc: Discovery document for building the Financial Services API + as described `here <https://cloud.google.com/financial-services/anti-money-laundering/docs/reference/rest#discovery-document>`__ + :param gcp_conn_id: Identifier of connection to Google Cloud Platform. + Defaults to "google_cloud_default". + """ + + connection: Resource | None = None + + def __init__( + self, + discovery_doc: dict, + gcp_conn_id: str = "google_cloud_default", + **kwargs, + ) -> None: + if kwargs.get("delegate_to") is not None: + raise RuntimeError( + "The `delegate_to` parameter has been deprecated before and finally" + " removed in this version" + " of Google Provider. You MUST convert it to `impersonate_chain`" + ) + super().__init__( + gcp_conn_id=gcp_conn_id, + impersonation_chain=None, + ) + self.discovery_doc = discovery_doc + + def get_conn(self) -> Resource: Review Comment: The credentials retrieved using `GoogleBaseHook ` don't authenticate the Financial Services; for this service a developer key should be provided due to the API is not currently being publicly General Available. For some use cases, we expect that providing the discovery document may be more feasible than creating and sharing an API key in GCP. However, I agree that having the option to use the developer key could also be useful. I have made updates to enable users to supply either a developer API key OR a discovery document as a local .json file by setting Airflow variables. An exception will be raised if neither of these variables are set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
