claw89 commented on code in PR #43446: URL: https://github.com/apache/airflow/pull/43446#discussion_r1826208446
########## providers/src/airflow/providers/google/cloud/sensors/financial_services.py: ########## @@ -0,0 +1,65 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING, Sequence + +from airflow.exceptions import AirflowFailException +from airflow.providers.google.cloud.hooks.financial_services import FinancialServicesHook +from airflow.sensors.base import BaseSensorOperator, PokeReturnValue + +if TYPE_CHECKING: + from airflow.utils.context import Context + + +class FinancialServicesOperationSensor(BaseSensorOperator): Review Comment: Several factors affect the feasibility of following the standard `wait_for_operation` pattern: - we don't currently have a python client API for Financial Services - type URLs are not registered for the Financial Services API types I have pushed a possible solution that patches the missing types with an `Empty` protobuf. The trade-of is that the operation metadata and instance data aren't returned by the operator after parsing the the json response from a call to the Financial Services API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
