jscheffl commented on code in PR #43612:
URL: https://github.com/apache/airflow/pull/43612#discussion_r1827038161
##########
providers/src/airflow/providers/standard/utils/python_virtualenv.py:
##########
@@ -88,22 +130,33 @@ def prepare_virtualenv(
if pip_install_options is None:
pip_install_options = []
+ if requirements is not None and requirements_file_path is not None:
Review Comment:
I _think_ there was a reason behind this and the lines just have been moved
in order. There I'd propose to keep it. Even if the proposed shortage looks mot
Pythonic there could be cases where Non-Null values evaluate to False.
I just moved the line up to fail fast - else in previous code it was
creating the venv base and then raising an exception. Not if fails before venv
is started to be created.
The line is originating from long long time ago from
https://github.com/apache/airflow/pull/17349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
