potiuk commented on code in PR #43612:
URL: https://github.com/apache/airflow/pull/43612#discussion_r1827059300
##########
providers/src/airflow/providers/standard/utils/python_virtualenv.py:
##########
@@ -88,22 +130,33 @@ def prepare_virtualenv(
if pip_install_options is None:
pip_install_options = []
+ if requirements is not None and requirements_file_path is not None:
Review Comment:
Yes @jscheffl is right - requirements migh be "empty" (as result of
templating) and this would evaluate to "no requirements" (but `pip install -r`
would fail) similarly requirements_file might be templated and empty result
would mean "no requirements" rather than trying to do `pip install -r ""`
(which would also fail)..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
