kaxil commented on code in PR #43767:
URL: https://github.com/apache/airflow/pull/43767#discussion_r1833053306


##########
airflow/api_fastapi/execution_api/schemas.py:
##########
@@ -119,3 +119,30 @@ class TIHeartbeatInfo(BaseModel):
 
     hostname: str
     pid: int
+
+
+class ConnectionResponse(BaseModel):
+    """Connection serializer for responses."""
+
+    conn_id: str
+    conn_type: str
+    description: str | None
+    host: str | None
+    schema_: str | None = Field(alias="schema")

Review Comment:
   Some of the key differences for this one are that we aren't redacting 
passwords or contents of "extra".  and the good thing is we can change response 
model whenever we want since it is internal so IMO while some of it is 
redundant, it is still fine



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to