howardyoo commented on PR #40802: URL: https://github.com/apache/airflow/pull/40802#issuecomment-2462951640
I understand. However, I know some of the airflow users would like to have task logs sent out as span events - and would see those as good value (hence the implementation). Currently, the ability for task logs to be emitted is configurable, meaning that you can turn it off it it becomes problematic. How about some additional options to the configs for making this feature not be removed, but provided as an option: - providing way to limit the max size of the task log, e.g. have the maximum limit to emit the first N characters (e.g. first 32k characters), and trim off any subsequent logs so that if they want to view the rest of the log, they can use the log link. The OTEL log implementation is just yet another structure that closely resembles the span event, so simply using the log sdk won't resolve this. However, I believe having the option for default limit (we can settle in for such as first 64k characters) and then having option to either limit or increase the limit based on user's preference could be something. Any opinions on this? On Thu, Nov 7, 2024 at 11:04 AM Jed Cunningham ***@***.***> wrote: > There could be Mbs of task logs potentially. > > In the wild, we see logs big enough to OOM the webserver. I'd imagine the > same would happen for the scheduler too. Definitely problematic, beyond > just being slow. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/40802#issuecomment-2462779221>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AHZNLLRWF327WCSKMDPRXC3Z7OMSLAVCNFSM6AAAAABK5KFCK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSG43TSMRSGE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
