ephraimbuddy commented on code in PR #43492:
URL: https://github.com/apache/airflow/pull/43492#discussion_r1836693192
##########
airflow/models/dag_version.py:
##########
@@ -136,7 +136,8 @@ def get_latest_version(cls, dag_id: str, *, session:
Session = NEW_SESSION) -> D
def get_version(
cls,
dag_id: str,
- version_number: int = 1,
+ version_number: int | None = None,
+ version_name: str | None = None,
Review Comment:
The version number is incremented each time there's a structural change to
the DAG, while the version name does not change. You can have all the DAGs with
the same version name. I think for display, having
`version_name-version_number` would be good. However, I'm wondering if we
really need the version_name @jedcunningham.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
