jedcunningham commented on code in PR #43492:
URL: https://github.com/apache/airflow/pull/43492#discussion_r1838414646
##########
airflow/models/dag_version.py:
##########
@@ -136,7 +136,8 @@ def get_latest_version(cls, dag_id: str, *, session:
Session = NEW_SESSION) -> D
def get_version(
cls,
dag_id: str,
- version_number: int = 1,
+ version_number: int | None = None,
+ version_name: str | None = None,
Review Comment:
> From the UI perspective, how should users search for DAG version?
I'm not sure we really want users searching by DAG version, but it'd be more
informational.
If we did, however, I think letting folks go by either would be fine. But it
would be in the context of "dag runs for version x", moreso than searching for
versions directly. None of that is planned at the moment afaik though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
