potiuk commented on code in PR #43769:
URL: https://github.com/apache/airflow/pull/43769#discussion_r1836728137
##########
dev/breeze/src/airflow_breeze/utils/packages.py:
##########
@@ -420,7 +420,12 @@ def get_dist_package_name_prefix(provider_id: str) -> str:
def apply_version_suffix(install_clause: str, version_suffix: str) -> str:
- if install_clause.startswith("apache-airflow") and ">=" in install_clause
and version_suffix:
+ if (
+ install_clause.startswith("apache-airflow")
+ and ">=" in install_clause
+ and version_suffix
+ and not is_local_version_suffix(version_suffix)
Review Comment:
Hmm. I think we should support BOTH pypi and local suffix. It's really
likely that we want to have
rc1+local-tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
