perry2of5 commented on code in PR #43769:
URL: https://github.com/apache/airflow/pull/43769#discussion_r1843040356
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -926,7 +936,8 @@ def prepare_provider_packages(
include_removed=include_removed_providers,
include_not_ready=include_not_ready_providers,
)
- if not skip_tag_check:
+ package_version = create_package_version(version_suffix_for_pypi,
version_suffix_for_local)
+ if not skip_tag_check and not is_local_package_version(package_version):
run_command(["git", "remote", "rm", "apache-https-for-providers"],
check=False, stderr=DEVNULL)
make_sure_remote_apache_exists_and_fetch(github_repository=github_repository)
Review Comment:
I'm not totally convinced we want to ignore the github_repository flag if it
is a local build any more. When it was just a local provider build, it seemed
okay. Now I have concerns and I'm not sure if I need to investigate this. Any
thoughts, @potiuk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
