jaklan commented on PR #43453: URL: https://github.com/apache/airflow/pull/43453#issuecomment-2469913393
>Sorry if you were a bit too much put-off inititally, and if I was a bit too harsh, but this OSS world is a bit different than traditional and the "top-bottom" thing does not work here - much more responsibility is in the hands of contributors. @potiuk Sure, we get this point, but that's exactly the reason why we had doubts about the best way to move forward. It's just a single-line change, but - breaking change. And the fact we expect the Operator to behave differently doesn't mean it's the same for other users, maybe for most of them the existing behaviour was actually fine? That's why we wanted to ensure first there was a common agreement to change the logic, but if there is no direct ownership of the Operator - then I believe we should be even more cautious about introducing breaking changes, which could be avoided for example in one of the above ways: > * introducing a new parameter `rerun_from_failure` and deprecating `retry_from_failure` (to differentiate dbt Cloud `rerun` - as that's the API endpoint - from Airflow task `retry`) > or > * keeping `retry_from_failure`, but supporting all options like: `True | False | "never" | "always" | "when_task_retried"` and a) marking `True | False` as deprecated b) keeping the mapping `True -> "always"`, `False -> "never"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
