joellabes commented on PR #43453: URL: https://github.com/apache/airflow/pull/43453#issuecomment-2474745382
Hey! I'm the DX advocate for the orchestration team at dbt Labs. I think this approach (only issue a rerun command if it's an Airflow retry) makes sense. It aligns with the behaviour in the run results UI for dbt Cloud, where the only way you can trigger a rerun is to have a job which has partially failed. So it should match up with folks' mental models pretty nicely. As for the tradeoffs between the possible approaches, I think it would have been useful to flag that it was a breaking change when the PR was opened, as opposed to [after the merge had happened](https://github.com/apache/airflow/pull/43453#issuecomment-2466681024). The initial issue enumerated the options but didn't explicitly call out the tradeoffs associated with each one. (To be clear, I do think you made the right choice in _not_ adding a new option/parameter, since the change aligns with the mental model of the feature in dbt Cloud so should be uncontroversial.) Thanks for your contribution to the operator! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
