dstandish commented on code in PR #43853:
URL: https://github.com/apache/airflow/pull/43853#discussion_r1838990126
##########
providers/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -565,6 +585,31 @@ def _reconcile_requested_log_containers(
self.log.error("Could not retrieve containers for the pod: %s",
pod_name)
return containers_to_log
+ def fetch_requested_init_container_logs(
Review Comment:
Roger. And to be clear my question is genuine and not a subtle way of
saying "you must do this".
But, back to the matter, it looks like `fetch_requested_container_logs` does
process the logs sequentially, doesn't it? Looks like the only difference is
you add "await start". Is that actually necessary? Why isn't it necessary with
non-init containers? Should we be doing it with non-init containers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
