dstandish commented on code in PR #43853:
URL: https://github.com/apache/airflow/pull/43853#discussion_r1839001518
##########
providers/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -832,6 +883,20 @@ def _exec_pod_command(self, resp, command: str) -> str |
None:
return res
return None
+ def _await_init_container_start(self, pod: V1Pod, container_name: str,
sleep_timeout_seconds: float = 1):
Review Comment:
i was just saying it seems you don't use the param `sleep_timeout_seconds`
so it probably doesn't need to be there. not saying you should make it a
constant but it could just be a hardcoded number. just the principle of not
adding interface that you aren't actually using / doing the minimal thing.
you've made it a private function (which is great) so this means if we want to
change it later we can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
