vatsrahul1001 commented on code in PR #43881:
URL: https://github.com/apache/airflow/pull/43881#discussion_r1839843890
##########
airflow/api_fastapi/core_api/routes/public/assets.py:
##########
@@ -69,3 +79,46 @@ def get_assets(
assets=[AssetResponse.model_validate(asset, from_attributes=True) for
asset in assets],
total_entries=total_entries,
)
+
+
+@assets_router.get(
+ "/events",
+ responses=create_openapi_http_exception_doc([401, 403, 404]),
+)
+async def get_asset_events(
+ limit: QueryLimit,
+ offset: QueryOffset,
+ order_by: Annotated[
+ SortParam,
+ Depends(
+ SortParam(
+ ["timestamp", "source_dag_id", "source_task_id",
"source_run_id", "source_map_index"],
+ AssetEvent,
+ ).dynamic_depends("timestamp")
Review Comment:
I saw
[this](https://github.com/apache/airflow/blob/main/airflow/api_connexion/endpoints/asset_endpoint.py#L124)
in legacy code due to which I made this default. Also, noticed when I remove
default from timestamp its considering `id` as default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
