vatsrahul1001 commented on code in PR #43881:
URL: https://github.com/apache/airflow/pull/43881#discussion_r1840175375


##########
tests/api_fastapi/core_api/routes/public/test_assets.py:
##########
@@ -229,3 +303,94 @@ def test_should_respect_page_size_limit_default(self, 
test_client):
 
         assert response.status_code == 200
         assert len(response.json()["assets"]) == 100
+
+
+class TestGetAssetEvents(TestAssets):

Review Comment:
   @amoghrajesh here we are just verifying order by raises 400 for any invalid 
attr provided. Do you want me to cover any specific case here? Also,  I see in 
legacy 
[test](https://github.com/astronomer/airflow/blob/dc4def7c87441554ff106e65ec2b7894cdba7b0e/tests/api_connexion/endpoints/test_asset_endpoint.py#L180)
 we are only validating same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to