kaxil commented on code in PR #43966:
URL: https://github.com/apache/airflow/pull/43966#discussion_r1840491882
##########
airflow/config_templates/config.yml:
##########
@@ -1064,17 +1064,24 @@ metrics:
example: "\"scheduler,executor,dagrun,pool,triggerer,celery\"
or \"^scheduler,^executor,heartbeat|timeout\""
default: ""
- metrics_consistency_on:
- description: |
- Enables metrics consistency across all metrics loggers (ex: timer and
timing metrics).
+ # TODO: Remove 'timer_unit_consistency' in Airflow 3.0
+ timer_unit_consistency:
+ description: |
+ Controls the consistency of timer units across all metrics loggers
+ (e.g., Statsd, Datadog, OpenTelemetry)
+ for timing and duration-based metrics. When enabled, all timers will
publish
+ metrics in milliseconds for consistency and alignment with Airflow's
default
+ metrics behavior in version 3.0+.
.. warning::
- It is enabled by default from Airflow 3.
- version_added: 2.10.0
+ It will be the default behavior from Airflow 3.0. If disabled,
timers may publish
+ in seconds for backwards compatibility, though it is recommended to
enable this
+ setting to ensure metric uniformity and forward-compat with Airflow
3.
+ version_added: 2.11.0
type: string
example: ~
- default: "True"
Review Comment:
`True` would have broken behavior on 2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
