kaxil commented on PR #43966: URL: https://github.com/apache/airflow/pull/43966#issuecomment-2474314602
> I like the name change, but the default being "on" was discussed in the PR where it was added](#39908), why are we changing it now? This is a "breaking change" in that it requires adjusting StatsD dashboards, but it is being applied in 3.0 which is the time to do such changes, right? The last I heard in discussions was that StatsD was being moved to second-class and OTel Metrics were supposed to be treated as the standard starting in 3.0 > > Please read through the conversation on the other PR and reconsider this change. A few things: - The version-added in this one was still `version_added: 2.10.0` - Airflow 3 will already remove this, check PR description where it says: "We should backport this to 2.11 and remove this setting from Airflow main" including the newsfragment. The idea is to keep it "off" for 2.11 so users get advanced warning and they can migrate early if they want without breaking and of their current tools. The main behaviour still says the same once we remove it, there is also a TODO I had added in this PR, please let me know if that isn't what you wanted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
