ArshiaZr commented on code in PR #43340:
URL: https://github.com/apache/airflow/pull/43340#discussion_r1840495410
##########
airflow/metrics/datadog_logger.py:
##########
@@ -66,109 +96,95 @@ def __init__(
self.metrics_tags = metrics_tags
self.metric_tags_validator = metric_tags_validator
+ @prepare_stat_with_tags
@validate_stat
def incr(
self,
- stat: str,
+ metric_name: str,
count: int = 1,
rate: float = 1,
*,
- tags: dict[str, str] | None = None,
+ tags: list[str] | None = None,
Review Comment:
Since Datadog expecting a list I don't think if we can do better here. Since
the decorator would be called first, it does not break any test cases. I can
revert it back, but there would be many redundant codes for each of the
functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
