ArshiaZr commented on code in PR #43340:
URL: https://github.com/apache/airflow/pull/43340#discussion_r1829807969
##########
airflow/metrics/datadog_logger.py:
##########
@@ -51,7 +55,33 @@
)
Review Comment:
There are two differences mainly that's why I didn't do that:
1. Tags Format:
prepare_stat_with_tags converts tags into a tags_list (e.g., ["key:value"])
for use in kwargs.
prepare_metric_name_with_tags keeps tags as a dictionary, formatted for
InfluxDB.
2. Return Behavior:
prepare_stat_with_tags runs the function directly with tags_list in kwargs.
prepare_metric_name_with_tags returns a modified metric_name with tags if
influxdb_tags_enabled is True.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
