Lee-W commented on code in PR #43949:
URL: https://github.com/apache/airflow/pull/43949#discussion_r1843317023
##########
airflow/cli/commands/dag_command.py:
##########
@@ -537,8 +538,8 @@ def dag_test(args, dag: DAG | None = None, session: Session
= NEW_SESSION) -> No
@provide_session
def dag_reserialize(args, session: Session = NEW_SESSION) -> None:
"""Serialize a DAG instance."""
-
session.execute(delete(SerializedDagModel).execution_options(synchronize_session=False))
+ if args.clear_history:
Review Comment:
> I updated the command to ensure users know it will delete DAG history and
answer yes for it to continue.
I thought we needed some prompts here to confirm with users. Or are we doing
it elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
