ephraimbuddy commented on code in PR #43949:
URL: https://github.com/apache/airflow/pull/43949#discussion_r1843464929
##########
airflow/cli/commands/dag_command.py:
##########
@@ -537,8 +538,8 @@ def dag_test(args, dag: DAG | None = None, session: Session
= NEW_SESSION) -> No
@provide_session
def dag_reserialize(args, session: Session = NEW_SESSION) -> None:
"""Serialize a DAG instance."""
-
session.execute(delete(SerializedDagModel).execution_options(synchronize_session=False))
+ if args.clear_history:
Review Comment:
I need to update the description. I later changed it so that users must
specify clearly before we delete anything. We no longer need the question.
Previously, a`irflow dag reserialise` would delete the serialized dag. I
modified it to ask questions before deleting the serdag and later removed that,
requesting that users clearly specify that they are deleting with
--clear-history before we do the deletion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
