eladkal commented on code in PR #44055:
URL: https://github.com/apache/airflow/pull/44055#discussion_r1844135196
##########
providers/src/airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -666,6 +670,7 @@ def __init__(
job_flow_overrides: str | dict[str, Any] | None = None,
region_name: str | None = None,
wait_for_completion: bool = False,
+ wait_for_steps_completion: bool = False,
Review Comment:
I think both `wait_for_completion` and `wait_for_steps_completion` can be
very confusing.
If we are to support the new functionality I suggest to introduce a new
parameter `wait_policy` which will accept value of `wait_for_steps_completion`,
`wait_for_steps_completed_and_machine_terminated` similar to what we did with
Kubernetes in https://github.com/apache/airflow/pull/30718 when we had more
than just a bool option for delete pod.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
