eladkal commented on code in PR #44055:
URL: https://github.com/apache/airflow/pull/44055#discussion_r1847170835
##########
providers/src/airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -636,8 +641,14 @@ class EmrCreateJobFlowOperator(BaseOperator):
:param job_flow_overrides: boto3 style arguments or reference to an
arguments file
(must be '.json') to override specific ``emr_conn_id`` extra
parameters. (templated)
:param region_name: Region named passed to EmrHook
- :param wait_for_completion: Whether to finish task immediately after
creation (False) or wait for jobflow
+ :param wait_for_completion: Deprecated - use `wait_policy` instead.
+ Whether to finish task immediately after creation (False) or wait for
jobflow
completion (True)
+ (default: None)
+ :param wait_policy: Whether to finish the task immediately after creation
(None) or:
+ - wait for the jobflow completion (WaitPolicy.WAIT_FOR_COMPLETION)
+ - wait for the jobflow completion and cluster to terminate
(WaitPolicy.WAIT_FOR_STEPS_COMPLETION)
+ (default: None)
:param waiter_max_attempts: Maximum number of tries before failing.
Review Comment:
Can you add the explnation about the parameter also to the emr docs?
Also lets verify if we have example dags using the old parameter and switch
them to the new one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
