romsharon98 commented on code in PR #43606:
URL: https://github.com/apache/airflow/pull/43606#discussion_r1846436270
##########
helm_tests/airflow_aux/test_basic_helm_chart.py:
##########
@@ -549,19 +549,20 @@ def test_supported_executor(self, executor):
)
def test_unsupported_executor(self):
- with pytest.raises(CalledProcessError) as ex_ctx:
+ with pytest.raises(CalledProcessError):
render_chart(
"test-basic",
{
"executor": "SequentialExecutor",
},
)
- assert (
- 'executor must be one of the following: "LocalExecutor", '
- '"LocalKubernetesExecutor", "CeleryExecutor", '
- '"KubernetesExecutor", "CeleryKubernetesExecutor", '
- '"airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor", '
- '"airflow.providers.amazon.aws.executors.ecs.AwsEcsExecutor"' in
ex_ctx.value.stderr.decode()
+
+ def test_support_multiple_executors(self):
Review Comment:
I think better combine those tests: test_support_multiple_executors,
test_supported_executor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
