romsharon98 commented on code in PR #43606:
URL: https://github.com/apache/airflow/pull/43606#discussion_r1847708118
##########
chart/values.schema.json:
##########
@@ -687,15 +687,7 @@
"type": "string",
"x-docsSection": "Common",
"default": "CeleryExecutor",
- "enum": [
- "LocalExecutor",
- "LocalKubernetesExecutor",
- "CeleryExecutor",
- "KubernetesExecutor",
- "CeleryKubernetesExecutor",
-
"airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor",
- "airflow.providers.amazon.aws.executors.ecs.AwsEcsExecutor"
- ]
+ "pattern":
"^(LocalExecutor|LocalKubernetesExecutor|CeleryExecutor|KubernetesExecutor|CeleryKubernetesExecutor|airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor|airflow.providers.amazon.aws.executors.ecs.AwsEcsExecutor)(,(LocalExecutor|LocalKubernetesExecutor|CeleryExecutor|KubernetesExecutor|CeleryKubernetesExecutor|airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor|airflow.providers.amazon.aws.executors.ecs.AwsEcsExecutor))*$"
Review Comment:
After this change, we can set executor="CeleryExecutor,KubernetesExecutor".
Therefore, if there are tasks running on the KubernetesExecutor, we want to
filter out tasks meant for Celery by using a queue filter to decide whether to
increase the number of Celery workers.
Maybe @hussein-awala can help us to decide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
