pierrejeambrun commented on code in PR #44051:
URL: https://github.com/apache/airflow/pull/44051#discussion_r1847893891
##########
airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -322,7 +333,85 @@ def get_task_instances(
session,
)
- task_instances = session.scalars(task_instance_select).all()
+ task_instances = session.scalars(task_instance_select)
+
+ return TaskInstanceCollectionResponse(
+ task_instances=[
+ TaskInstanceResponse.model_validate(task_instance,
from_attributes=True)
+ for task_instance in task_instances
+ ],
+ total_entries=total_entries,
+ )
+
+
+@task_instances_router.post(
+ "/list",
Review Comment:
Yes I think we need to manually constraint those. (It was enforced by
connexion before, we need it done in pydantic as well).
PR here https://github.com/apache/airflow/pull/44175
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
