pierrejeambrun commented on code in PR #44051:
URL: https://github.com/apache/airflow/pull/44051#discussion_r1844237008
##########
airflow/api_fastapi/core_api/datamodels/task_instances.py:
##########
@@ -83,3 +91,26 @@ class TaskDependencyCollectionResponse(BaseModel):
"""Task scheduling dependencies collection serializer for responses."""
dependencies: list[TaskDependencyResponse]
+
+
+class TaskInstancesBatchBody(BaseModel):
+ """Task Instance body for get batch."""
+
+ dag_ids: list[str] | None = None
+ dag_run_ids: list[str] | None = None
+ task_ids: list[str] | None = None
+ state: list[TaskInstanceState | None] | None = None
+ logical_date_gte: AwareDatetime | None = None
+ logical_date_lte: AwareDatetime | None = None
Review Comment:
I think that as long as the timezone is specified, there is no ambiguity.
Because comparison is correct in the server, and then when persisted to the db
it gets converted to UTC (at least that's what I remember from postgres, it
actually depends on the type of date but usually its like this, and get back
from DB in utc tzaware).
##########
airflow/api_fastapi/core_api/datamodels/task_instances.py:
##########
@@ -83,3 +91,26 @@ class TaskDependencyCollectionResponse(BaseModel):
"""Task scheduling dependencies collection serializer for responses."""
dependencies: list[TaskDependencyResponse]
+
+
+class TaskInstancesBatchBody(BaseModel):
+ """Task Instance body for get batch."""
+
+ dag_ids: list[str] | None = None
+ dag_run_ids: list[str] | None = None
+ task_ids: list[str] | None = None
+ state: list[TaskInstanceState | None] | None = None
+ logical_date_gte: AwareDatetime | None = None
+ logical_date_lte: AwareDatetime | None = None
Review Comment:
I think that as long as the timezone is specified, there is no ambiguity.
Because comparison is correct in the server, and then when persisted to the db
it gets converted to UTC (at least that's what I remember from postgres, it
actually depends on the type of date but usually its like this, and comes back
from DB in utc tzaware).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
