potiuk commented on PR #42658: URL: https://github.com/apache/airflow/pull/42658#issuecomment-2489959330
> Can anyone comment on why we are doing this? > @vikramkoka > @dirrao Why did we make a breaking change here? @vikramkoka @dirrao I made a very quick check now and quick git blame on that #TODO shows it was added by @jedcunningham here https://github.com/apache/airflow/pull/26357 explaining why the #TODO was there and mentions previous attempt of doing it https://github.com/apache/airflow/pull/25978 - and I also suggest to look for those things when you look for sources, because we are all humans and make mistakes and it only takes a very little (took me about 2 minutes). search through our repository if we accidentally missed that newsfragment here - without unnecesary raising the tone of the discussion and finger-pointing people. I think it's a good thing that we collaborate here, and cover each-others' back when we make mistake rather than point at theme. And yes, if it is still legitimate (@jedcunningham) It should be included in newsfragment (and this is what we all forgot to ask @dirrao to do here - althought in pronbably other 500 of those we did not). I simply thing collaboration and gentle - possibly even humorous - way of pointing out mistakes rather than fingerpointing is a better way to build collaboration spirit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
