dirrao commented on PR #42658:
URL: https://github.com/apache/airflow/pull/42658#issuecomment-2491339591

   > @dirrao why? Was there a mailing list discussion about it?
   > 
   > In future please include the "why" and the context in the PR descriptions. 
Right now we are in the dark as to the reason for this change!
   > 
   > > * Adhere to guidelines for commit messages described in this 
[article](https://cbea.ms/git-commit/). This makes the lives of those who come 
after you (and your future self) a lot easier.
   
   Thank you for the feedback, and I completely understand the concern about 
the lack of context in the PR description.
   
   To clarify, this change was made based on the comment in the code:
   `TODO: convert this to a positional arg in Airflow 3.`
   
   Moving forward, future PRs will include detailed explanations of the "why" 
and any relevant context. Please let me know if there’s anything I might have 
missed or any additional action required on my side.
   
   Thank you for highlighting this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to