jieyao-MilestoneHub opened a new pull request, #44302:
URL: https://github.com/apache/airflow/pull/44302
This PR adds an `adapter` parameter to the `HttpHook`, allowing users to
mount custom adapters for HTTP request handling. This enhances flexibility and
supports use cases like custom retries, timeouts, and SSL handling.
### Summary of Changes:
- Added `adapter` parameter to `HttpHook` to allow custom HTTP adapters.
- Modified `get_conn` to support mounting custom adapters or using
TCPKeepAliveAdapter by default.
- Added comprehensive tests to validate the functionality of the `adapter`
parameter and its integration with `get_conn`.
- Ensured all new tests pass and maintain compatibility with existing
functionality.
### Issue Reference:
Closes #44285
### Testing and Validation:
- Added unit tests in `~/providers/tests/http/hooks/test_http.py` to
validate:
- Mounting custom adapters.
- Default behavior when no adapter is provided.
- Handling invalid adapter types.
- Ran `pytest providers/tests/http/hooks/test_http.py` using breeze.
- Pass `pre-commit run --files
providers/src/airflow/providers/http/hooks/http.py
providers/tests/http/hooks/test_http.py` using breeze.
### Backward Compatibility:
This change is backward-compatible. The new `adapter` parameter is optional
and defaults to None, preserving existing behavior.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
