shahar1 commented on PR #44302: URL: https://github.com/apache/airflow/pull/44302#issuecomment-2495512067
> Thank you, @shahar1, for your detailed review and valuable feedback! I’ve addressed your comments by: > > 1. Adding a detailed docstring for the `__init__` method, including the missing `adapter` parameter. > 2. Removing the redundant instantiation of `TCPKeepAliveAdapter` in the `run` method. > > Please let me know if there’s anything else I can improve. I really appreciate your time and support! Thanks :) Regarding the 2nd point - could you please explain why it makes sense to relocate the instanation of `TCPKeepAliveAdapter` to the `__init__`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
