potiuk commented on code in PR #44283:
URL: https://github.com/apache/airflow/pull/44283#discussion_r1855522653
##########
airflow/models/slamiss.py:
##########
@@ -44,3 +49,7 @@ class SlaMiss(Base):
def __repr__(self):
return str((self.dag_id, self.task_id,
self.execution_date.isoformat()))
+
+ @property
Review Comment:
We could also potentially have `v2-11-test` branch at some point of time
(this is mostly the matter of how many changes like that we are going to have).
Theorethically, there is nothing wrong with having both branches created and
having Pull Requests to v2-11-test. We could then later rebase v2-11-test on
top of v2-10-test. - but that basically means that someone who merges changes
now would have to resolve the conflicts if that happens - or maybe put the
whole weitght of this resolving on the shoulders of release manager - both are
not too good ideas, likely keeping such changes as DRAFT PR and rebasing them
individually/merging PRs later is a better idea - as it puts the burden on
solving the issue on the one who is author (i.e. knows best what the intention
and context was).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
