ephraimbuddy commented on code in PR #44283:
URL: https://github.com/apache/airflow/pull/44283#discussion_r1855890653
##########
airflow/models/slamiss.py:
##########
@@ -44,3 +49,7 @@ class SlaMiss(Base):
def __repr__(self):
return str((self.dag_id, self.task_id,
self.execution_date.isoformat()))
+
+ @property
Review Comment:
> Likely keeping such changes as DRAFT PR and rebasing them
individually/merging PRs later is a better idea - as it puts the burden on
solving the issue on the one who is author (i.e. knows best what the intention
and context was).
I prefer this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
